Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • logilab-common logilab-common
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • open-source
  • logilab-commonlogilab-common
  • Merge requests
  • !10

class deprecated metaclass conflict

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Laurent Peuch requested to merge topic/default/fix-class-deprecated-metaclass-conflict into branch/default May 07, 2020
  • Overview 2
  • Commits 2
  • Pipelines 6
  • Changes 2

Hello,

Has describe in the test if you have different metaclass this will break all this current code. There was a situation before that was here to handle compatibility with python2 which by side effect solve this issue, see https://forge.extranet.logilab.fr/open-source/logilab-common/blob/1.5.2/logilab/common/deprecation.py#L126

While doing this I realized that the previous solution was actually way simpler and didn't present this bug and I don't understand why it has been chosen to move to a metaclass strategy so I simply went back to this previous approach.

This situation breaks CubicWeb sadly, I'm going to see if we can launch tests from other project in this CI to see if we breaks them.

Kind regards,

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: topic/default/fix-class-deprecated-metaclass-conflict