Skip to content

Topic/default/better ux on nonselectable error

Laurent Peuch requested to merge topic/default/better-ux-on-nonselectable-error into branch/default

Had to look at CW code again yesterday, got annoyed again, here is a series of fixes on this specific part of the code:

  • restraint exception scope only to the concern pat (actually my fault here)
  • rename all the inner variable because even some of those doesn't make sens regarding their name (it's not a view registry!)
  • do a real error message because hiding the real exception is how to make a debugging hell
  • (this one is a BREAKING change!) change the "unauthorized" (401) to "badrequest" (400) because nothing tells you that CW not being able to find a controller means that /all the time/ this is an unthorization problem by it might be sometime (we lack granularity here)

I recommend reading commit by commit instead of the whole diff.

Merge request reports