[test] Setup S3Storage in a hook
Instead of doing storage attribution in test setup, we implement a test hook (in test/data/hook.py) as would be done in real application. As a consequence, we change the way s3 requests are mocked (using moto). Namely, we introduce a "_s3_client" class method in S3Storage that is mocked in test setup so that mocking operates in the test hook. In migration tests, instead of instantiating a new storage object, we reuse the one bound to Image's data attribute so as to benefit from the active mock.
Showing
- cubicweb_s3storage/storages.py 5 additions, 1 deletioncubicweb_s3storage/storages.py
- cubicweb_s3storage/testing.py 16 additions, 9 deletionscubicweb_s3storage/testing.py
- test/data/hooks.py 12 additions, 0 deletionstest/data/hooks.py
- test/test_s3storage.py 7 additions, 21 deletionstest/test_s3storage.py
Loading
Please register or sign in to comment