Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • file file
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cubicweb
  • cubes
  • filefile
  • Merge requests
  • !34

Merged
Created May 05, 2022 by Simon Chabot@schabotMaintainer

Update data_format on data change

  • Overview 2
  • Commits 1
  • Pipelines 3
  • Changes 2

Before that patch, and in the context of an update thought a form, the data, and format as resent.

If the user changes the data, he usually expects the format attribute to be automatically updated too. But it was not.

With this patch, if the data is changed, and the data_format is the same as before, we assume it has not been updated by the user, and that it should be recomputed. On the other hand, if the value is different than the previous one, we assume it has been changed by the user and we keep this value.


Before that patch, the suggested test fails as follow

image

Edited May 05, 2022 by Simon Chabot
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: topic/default/update-data_format