test/unittest_comment.py · effacbbd2d104fc6e178212b5af129c9ba5d2fa3 · cubicweb / cubes / comment

5 years ago

[views] fix possible infinite recursion loop in rssitem view · effacbbd2d10

Philippe Pepiot authored 5 years ago

I found this while executing some AutomaticWebTest on dependent cubes, but this case can occur anyway.

rssitem call rssitem view recursively following "comments" relation, so we may
enter in a loop here.

Fix this by using a "seen" set() which is passed resursively and we skip
already processed entities.
Add a basic test using a comment commenting a comment commenting the first one.

effacbbd2d10

History

[views] fix possible infinite recursion loop in rssitem view

Philippe Pepiot authored 5 years ago

I found this while executing some AutomaticWebTest on dependent cubes, but this case can occur anyway.

rssitem call rssitem view recursively following "comments" relation, so we may
enter in a loop here.

Fix this by using a "seen" set() which is passed resursively and we skip
already processed entities.
Add a basic test using a comment commenting a comment commenting the first one.