Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • RQL RQL
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cubicweb
  • RQLRQL
  • Merge requests
  • !63

Merged
Created Nov 24, 2021 by Nsukami Patrick@nsukamiMaintainer

[mypy]: Add type hints for EtypeResolver class:

  • Overview 14
  • Commits 11
  • Pipelines 6
  • Changes 4
Within rql/analyze.py:
----------------------
  add (line 403):
      if self.uid_func:
  and fix:
      error: "None" not callable  [misc]

  add (line 548):
      assert self.uid_func_mapping is not None
  and fix:
      Unsupported right operand type for in ("Optional[Dict[Any, Any]]")

  change (line 615):
      etypes = frozenset(t for t in self._nonfinal_domain if t not in etypes)
  to:
      etypes = set(t for t in self._nonfinal_domain if t not in etypes)
  and fix:
      Incompatible types in assignment (expression has type "FrozenSet[str]", variable has type "Set[Any]")


Within rql/interfaces.py:
-------------------------

Update ISchema protocol definition:
    add:
        def __contains__():
    and fix:
         error: Unsupported right operand type for in ("ISchema")  [operator]

    add:
        def rschema(self, rtype: Any):
    and fix:
        "ISchema" has no attribute "rschema"  [attr-defined]

    add:
        def eschema(self, etype: Any):
    and fix:
        "ISchema" has no attribute "eschema"  [attr-defined]

See RQL's issue: #15 (closed)

Edited Nov 24, 2021 by Nsukami Patrick
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: topic/default/etyperesolver