Skip to content

[mypy] Typing rql/base.py module

Nsukami Patrick requested to merge topic/default/adding-more-types into branch/default

Dear Pythonistas, really hope you're all doing fine. The following is an attempt (the first one) to type the base.py module. Thanks a lot for your time, advices and suggestions.

Some questions:

  • what is the intent with __slots__? Reduce the objects size? Or reduce the permitted attributes?
  • Should we rewrite BaseNode as an abstract class?
Edited by Nsukami Patrick

Merge request reports