GitLab

Drop debian from sdist
Include missing test files and tox.ini in sdist

Require python>=3 using setuptools python_requires and add "Programming Language :: Python :: 3 :: Only" specifier.
Also drop py2 specific code in __pkginfo__

This packaging only work for python2 and we're going to drop
python2 support.
I don't have an rpm build environment and I don't known how to test this, so
just drop the spec file and let someone revive this if needed.

In order to get the tests in the source Debian package we need
to ship them in the Python package. That's why we turn the
'test' directory into a Python package and remove the explicit
ignore from `setup.py`.

The tests themselves will install PostgreSQL and MariaDB. They
are thus marked `isolation-container` and need at least the
the lxc autopkgtest runner to be started.

We clean up most of debian/rules by using dh-python properly.

Tests are best skipped at build time because they require running
database to be meaningful. They will be implemented using autopkgtest.

This follows-up on changeset 9f2071ae3b26 (2013) in which this
COUNTDISTINCT function got introduced to replace COUNT(X, True) usage
(deprecated since version 1.10). Unfortunately, the implementation is
buggy as it uses the "name" attribute of the COUNTDISTINCT class to
generate the equivalent SQL and there exists no COUNTDISTINCT keyword in
SQL. I think the intended implementation is to convert COUNTDISTINCT(X)
into COUNT(DISTINCT X) instead (as this is done in the
backward-compatibility layer in COUNT.as_sql()).

There is no test for all this unfortunately.

When all tests are run together, the "sqlite" adapter may have already
been initialized by another test. So
test_only_one_lazy_module_initialization will break on its first
assertion. Following review discussion, there appears to be no simple
way to handle this so we mark the test as expected failure so that it
does not break in CI environment (or tox) but it might still succeed
when unittest_sqlite.py is run independently.

In a downstream project (cubicweb-rememberme), we get into this
convert_timedelta() function with a bytes value on Python 3. So all
string operations (.split()) will fail if their argument is not bytes as
well. So use bytes literal in every place needed in this function.

Could not get pytest working, so fall back to unittest discover, still
better than lgc's pytest.

This test (as far as I understand) checks for registration of functions
by a backend helper. It used mysql helper to detect unregistered
functions but there's nothing specific to mysql in this process, so we
now use sqlite instead.

In logilab-common, pytest executable got renamed as logilab-pytest.
Until we get rid of lgc, at least use the proper executable name.

Handle posargs along the way.

Who cares about MySQL nowadays?

More seriously, this dependency requires compile-time mysql
libraries/executable and I have no time to investigate how to set this
up (especially in a CI environment).

The former will work with any Python 3 version.