logilab-common merge requestshttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests2020-08-26T18:51:31Zhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/26fix(deprecation): stacked decorators breaks getting the real callable __name_...2020-08-26T18:51:31ZLaurent Peuchfix(deprecation): stacked decorators breaks getting the real callable __name__ attributeHello,
This is yet another impossible deep magic bug.
Normally the test and the docstring should explain it all. Don't hesitate to ask if you have questions.
If it's merged I'll backport it on 1.7 (I didn't do the "put on 1.7 then mer...Hello,
This is yet another impossible deep magic bug.
Normally the test and the docstring should explain it all. Don't hesitate to ask if you have questions.
If it's merged I'll backport it on 1.7 (I didn't do the "put on 1.7 then merge into default" because branches have diverged a bit too much due to typing and stuff)
Kind regards,Fabien Amargerfabien.amarger@logilab.frFabien Amargerfabien.amarger@logilab.frhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/28feat(deprecation): add structured informations to deprecation warnings2020-10-09T07:49:55ZLaurent Peuchfeat(deprecation): add structured informations to deprecation warningsHello,
This is the structured deprecated warnings that we've discussed about.
Kind regards,Hello,
This is the structured deprecated warnings that we've discussed about.
Kind regards,Simon ChabotSimon Chabothttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/29doc: update Changelog2020-10-20T20:42:54ZLaurent Peuchdoc: update Changelog--HG--
branch : 1.7--HG--
branch : 1.7Fabien Amargerfabien.amarger@logilab.frFabien Amargerfabien.amarger@logilab.frhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/30feat: add tests to ensure that warnings target the correct line2020-10-21T12:08:30ZLaurent Peuchfeat: add tests to ensure that warnings target the correct lineAdd a lot of tests to ensure that deprecation warnings target the correct line in the correct file because this is super tricky to check and to code and this end regularly being broken (and we only detect that super late by looking and t...Add a lot of tests to ensure that deprecation warnings target the correct line in the correct file because this is super tricky to check and to code and this end regularly being broken (and we only detect that super late by looking and those warnings in another project)
And indeed, one warning was broken :<Simon ChabotSimon Chabothttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/32ci: integrate pytest-deprecated-warnings2020-12-01T16:23:27ZLaurent Peuchci: integrate pytest-deprecated-warningsHello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,Hello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,https://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/33chore(tox): add deb and pypi publish2020-12-17T16:31:09ZNoé Gaumontchore(tox): add deb and pypi publishhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/34Topic/default/fix debian2020-12-17T16:31:08ZKatia SaurfeltTopic/default/fix debianhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/35fix(registry): use TypedDict when python version >= 3.8, otherwise a Dict2021-01-05T11:02:42ZSimon Chabotfix(registry): use TypedDict when python version >= 3.8, otherwise a Dict- TypedDict is provided by the typing module for python >= 3.8
- TypedDict is provided by the typing_extensions module for typing_extensions >=
3.7.4
but this module is not available as debian buster package.
- mypy does not support ...- TypedDict is provided by the typing module for python >= 3.8
- TypedDict is provided by the typing_extensions module for typing_extensions >=
3.7.4
but this module is not available as debian buster package.
- mypy does not support condition types defined like that:
```
if CONDITION:
type = Dict
else:
type = TypedDict
```
and therefore it's not possible to conditionally declare the type.
but… it does support checks with python version or system platform (cf:
https://mypy.readthedocs.io/en/stable/common_issues.html#python-version-and-system-platform-checks).
Let's import TypedDict from typing when it's available (python >= 3.8), and use
it. Otherwise, let's use a simple dict.
related https://forge.extranet.logilab.fr/open-source/logilab-common/-/issues/9Noé GaumontNoé Gaumonthttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/36feat(configuration): better error message2021-03-17T09:19:10ZLaurent Peuchfeat(configuration): better error messageChange the error message from:
![image](/uploads/22690897ef0e739b74884a5e1c73f7b2/image.png)
To:
![image](/uploads/187f547a79da6f0cc1fb38f65028e1a5/image.png)
Tested against this MR https://forge.extranet.logilab.fr/cubicweb/cubicweb...Change the error message from:
![image](/uploads/22690897ef0e739b74884a5e1c73f7b2/image.png)
To:
![image](/uploads/187f547a79da6f0cc1fb38f65028e1a5/image.png)
Tested against this MR https://forge.extranet.logilab.fr/cubicweb/cubicweb/-/merge_requests/152/Arthur LutzArthur Lutzhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/37chore(yamllint): add and integrate yamllint2021-02-24T10:57:45ZLaurent Peuchchore(yamllint): add and integrate yamllintHello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,Hello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,Arthur LutzArthur Lutzhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/38chore(yamllint): ignore .tox and node_modules2021-02-26T16:51:38ZLaurent Peuchchore(yamllint): ignore .tox and node_modulesHello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,Hello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,Arthur LutzArthur Lutzhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/39chore(configuration.py): fix flake82021-03-17T13:21:02ZArthur Lutzchore(configuration.py): fix flake8Nicolas Chauvatnicolas.chauvat@logilab.frNicolas Chauvatnicolas.chauvat@logilab.frhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/40chore(cube-doctor): add cube-doctor.yml2021-04-21T01:15:01ZLaurent Peuchchore(cube-doctor): add cube-doctor.ymlHello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,Hello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,https://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/41fix: rql repo has been moved2021-04-30T14:47:16ZLaurent Peuchfix: rql repo has been movedHello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,Hello dear contributors,
This is an auto generated modification to help you improve the code base of logilab. If this commit is bad don't hesitate to close this MR and report it.
Kind regards,https://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/42ci: add test on python3.82021-06-16T07:21:02ZNoé Gaumontci: add test on python3.8https://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/43Topic/default/deprecated warnings2021-06-25T08:27:48ZSimon ChabotTopic/default/deprecated warningsSimon ChabotSimon Chabothttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/44fix(ux): list all available validator when one isn't matched2021-06-28T09:18:16ZLaurent Peuchfix(ux): list all available validator when one isn't matchedSmall UX improvement.Small UX improvement.https://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/45Topic/default/hg formatsource2021-07-29T04:10:58ZLaurent PeuchTopic/default/hg formatsourceautoflake, autopep8, pyupgrade and blackautoflake, autopep8, pyupgrade and blackhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/47fix(typing): correctly type `cached` decorator2022-01-17T08:49:41ZFrank Bessoufix(typing): correctly type `cached` decoratorFrank BessouFrank Bessouhttps://forge.extranet.logilab.fr/open-source/logilab-common/-/merge_requests/48feat: Add header_message in ConfigurationMixIn.generate_config2022-01-04T15:13:39ZNoé Gaumontfeat: Add header_message in ConfigurationMixIn.generate_configAllow helper message to be added in the beginning of the file.
This makes sure all the lines are properly commentedAllow helper message to be added in the beginning of the file.
This makes sure all the lines are properly commented