GitLab

It breaks CW because CW was using class_deprecated in a isinstance to select
the good views to uses.

for python < 3.6 those two types are not defined. In case of import error, let's
define them (in the exact same way they are defined in the re module of python
>= 3.7).

Otherwise donc cachedproperty.__doc__ returns "property" and not the expected docstring.

functools.wraps was breaking the behavior of LazyObject because it tried to
access attributes of the LazyObject that triggers an import which could
sometime fails in this situation where some modules are marked as deprecated
but aren't imported yet.

For example see https://forge.extranet.logilab.fr/cubicweb/cubicweb/blob/3.24.0/cubicweb/schemas/__init__.py#L51

(removed in
46942c92b21)

I don't know why it has been choosen to move to a metaclass but it actually
brings more problems and a more complex code that it brings benefits.

Actually the old compatibility code actually prevented this bug so back it up.

There was a missmatched combination of:

* the frame wasn't always correctly grabbed
* grabbing the frame in the situation of a decorator didn't make any sens, so
  switch to func.__module__
* the tests were bad and expected "[logilab.common]" while it should have been
  "[test_deprecation]" because it was there that the depreciation was declared