Skip to content

GitLab

Switch branch/tag
  1. 22 Jul, 2021 2 commits
  3. 21 Jul, 2021 1 commit
  5. 22 Jun, 2021 3 commits
  7. 16 Jun, 2021 2 commits
  9. 01 Jun, 2021 1 commit
  11. 16 Jun, 2021 1 commit
  13. 30 Apr, 2021 3 commits
  15. 29 Apr, 2021 1 commit
  17. 27 Apr, 2021 3 commits
  19. 23 Apr, 2021 2 commits
  21. 17 Feb, 2021 4 commits
  23. 08 Feb, 2021 2 commits
  25. 07 May, 2020 1 commit
  27. 08 May, 2020 1 commit
    • Simon Chabot's avatar
      fix(tests): test_chmod checks whether the permissions are the same as the source file · 8b49be4828fc
      Simon Chabot authored 
      test_chmod used to check that permission are 644, but this is not what is done
in the `process_resource` method. This function sets the permissions to the same
as the source file.

As a consequence, depending on your configuration (default umask for instance),
you may end up with the expected 644 permissions or… something else. (666 on our
gitlab-runner for instance).

To make the test consistent with what is done in the function, and consistent
with the initial purpose of this test [0], let's simply check that the
permissions of the source file and the compiled file are the same.

If it appears that this is not enough, a solution could be to enforce 644
permissions in the `process_resource` method, or give the expected permissions
through parameters.

[0]: https://www.cubicweb.org/ticket/17143773

--HG--
branch : 3.27
      8b49be4828fc
  29. 12 Apr, 2020 1 commit
  31. 10 Apr, 2020 1 commit
  33. 21 May, 2021 1 commit
  35. 15 Jun, 2021 3 commits
  37. 05 Mar, 2021 4 commits
  39. 03 Mar, 2021 1 commit
  41. 02 Mar, 2021 2 commits