Skip to content

GitLab

Switch branch/tag
  1. 06 Oct, 2015 2 commits
  3. 05 Oct, 2015 1 commit
  5. 23 Sep, 2015 2 commits
    • Julien Cristau's avatar
      [hooks/syncschema] make sure CWUniqueTogetherConstraintDelOp happens before CWConstraintDelOp · 22f330f829ae
      Julien Cristau authored 
      SQLServer refuses to index an unlimited text column, so we should drop
unique_together constraints (which imply an index) before we drop size
constraints.  Closes #5560601.
      22f330f829ae
    • Aurelien Campeas's avatar
      [hooks/syncschema] only call "ALTER TABLE" once when changing a size constraint · 80236876ee4d
      Aurelien Campeas authored 
      Until now we would:

- remove the old size constraint from the in-memory schema
- call update_rdef_column which removes the size restriction from the
  column's type
- add the new constraint object
- call update_rdef_column which adds the size restriction back

This breaks on SQL Server when the column is involved in an index (e.g.
as part of a multi-column unique constraint), because in the
intermediate stage the column's type is "nvarchar(max)", which is not
indexable.

Of course we must still detect the case where a size constraint is
really dropped and update the db schema accordingly.

Closes #5557633.
      80236876ee4d
  7. 02 Sep, 2015 1 commit
  9. 19 Jun, 2015 2 commits
  11. 18 Jun, 2015 1 commit
  13. 27 Mar, 2015 3 commits
  15. 18 Mar, 2015 1 commit
  17. 17 Mar, 2015 1 commit
  19. 18 Mar, 2015 3 commits
  21. 17 Mar, 2015 1 commit
  23. 13 Mar, 2015 1 commit
    • Denis Laxalde's avatar
      [web/views/rdf] Take the second element of XY equivalent for non final relation · a12e4459eee5
      Denis Laxalde authored 
      When given a Yams snippet of the form `<etype> <rtype>` ``xy.xeq()`` will
return the XML snippet equivalent to this relation in the form of a tuple
`(subject, rtype, object)` so ``item`` will always be a tuple here.

In fact, the correct code appears just a few lines above (around line 88) for
final relations so I guess this is a copy-paste mistake.

Closes #4745929.
      a12e4459eee5
  25. 11 Feb, 2015 1 commit
  27. 09 Mar, 2015 1 commit
  29. 12 Mar, 2015 3 commits
  31. 11 Mar, 2015 1 commit
    • Rémi Cardona's avatar
      [config] Lowercase the FQDN we get from the OS (closes #5040345) · 996cf2c0ec99
      Rémi Cardona authored 
      Browsers convert the host name part of URLs to lowercase.  This has the
unfortunate effect of triggering various CORS error messages in
CubicWeb (because the Origin: header will contain lowercase letters).

As per RFC 4343, host name comparison should be case-insensitive.  So
let's put it in lowercase when we grab it from the host system.  If
admins put uppercase letters in "host" or "base-url" in their
all-in-one.conf, then it's their fault.
      996cf2c0ec99
  33. 10 Mar, 2015 1 commit
    • Rémi Cardona's avatar
      [web/views] Honor 'action' attribute on AutomaticEntityForm, closes #4943392 · fbb370195199
      Rémi Cardona authored 
      On AutomaticEntityForms, get_action used to bypass the logic from
FieldsForm.form_action() which handles the 'action' attribute itself,
preventing callers from overriding it at selection time. This capability
is used by the inlinedit cube.

In a nutshell, we let the deprecated AutomaticEntityForm.get_action()
raise an AttributeError, which allows FieldsForm.form_action() to handle
it properly.
      fbb370195199
  35. 06 Mar, 2015 1 commit
  37. 18 Dec, 2014 1 commit
  39. 05 Mar, 2015 1 commit
  41. 27 Jan, 2015 1 commit
  43. 26 Jan, 2015 1 commit
  45. 05 Feb, 2015 2 commits
  47. 16 Jan, 2015 2 commits
  49. 15 Jan, 2015 1 commit
  51. 29 Jan, 2015 1 commit
  53. 10 Dec, 2014 1 commit
  55. 04 Dec, 2014 1 commit
  57. 29 Dec, 2014 1 commit
    • Christophe de Vienne's avatar
      [native] Change SQL errors log level. · 4b33246cb43c
      Christophe de Vienne authored 
      -   The SQL error itself is logged as 'info'.
-   The 'transaction has been rolled back' message is logged as 'debug'.

These log entries should not be critical:

-   If an error occur at the sql level, it will be transmitted as a CW error.
    The exception is raised and handled in a higher level function, which will
    decide if it is critical or not.

-   Admitting that rolling-back automatically on errors is wanted in some
    cases, it cannot be considered 'critical'. The caller will receive the
    original exception anyway, it is its job to decide if it is critical or
    not.

Closes #4801120
      4b33246cb43c