GitLab

~src/cubes refer to the $HOME/cubes directory of "src" user while ~/src/cubes
refer to $HOME/src/cubes directory of current user.

Since twisted support is gone.

* install using pip and with pyramid in a virtualenv
* link to pyramid.ini documentation
* Use pyramid to start application since twisted support is gone

Twisted web server is not used anymore and has been superseded by
pyramid many years ago. Furthermore, our usage is not compatible with
Python 3. So we drop the "etwist" sub-package.

As a consequence, "all-in-one" configuration type gets dropped as it was
Twisted-specific. We resurrect it in cubicweb/pyramid/config.py by only
keeping options used by the "pyramid". Similarly, we introduce a
AllInOneCreateHandler in cubicweb/pyramid/pyramidctl.py that is
basically the one that lived in cubicweb/etwist/twctl.py and is used to
create the "all-in-one" instance. Added a TODO here about "pyramid.ini"
that could be generated at the end of bootstrap() method.

In cubicweb/devtools/httptest.py, CubicWebServerTC is now equivalent to
CubicWebWsgiTC and the latter is dropped.

This is in preparation of dropping the Twisted web server backend.

We thus draw a clearer line between what's specific to twisted from
what's generic by moving WebConfigurationBase class into
cubicweb/web/webconfig.py and only keeping twisted-related in
AllInOneConfiguration (still living in cubicweb/etwist/twconfig.py).

This backend is not maintained, very likely no longer used in any recent
instance, and not supported in Python 3.

* run autopep8 on the file
* fixed unused imports
* rename "version" import as "cw_version" in order not to shadow local
  variables

This method generates code in a file using etwist module that we are
about to drop.

Until someone works on fixing these, this should make our CI green
again.

I tried to use setupModule() to check for python version, but
pre_setup_database() is apparently called even when a SkipTest exception
is raised there. So handle this in that method.

* remove mention of start/stop/restart/status commands that do not exist anymore
* briefly mention the "pyramid" and point to respective documentation page
* mention that a WSGI server should be used in production

This cube got merged into cubicweb several versions ago.

Drop dependency on cubicweb-file, cubicweb-blog and cubicweb-tag for cubicweb/web/test
Copy required parts of cubes (schema, entities, views and hooks) into
cubicweb/web/test/data/cubicweb-<cube> that make tests pass.

Drop dependency on cubicweb-file, cubicweb-localperms, cubicweb-tag and
cubicweb-comment for cubicweb.test and cubicweb.sobjects.test

Move cubicweb/test/data/libpython/cubicweb_* to cubicweb/test/data, so it's
included in PYTHONPATH.
Add missing parts of schema, entities, views, hooks that make tests pass.

This is used to test legacy cube import which is planned for removal
in cubicweb 3.27, so drop the code.

This is used to test legacy cube import which is planned for removal in
cubicweb 3.27, so drop the code.

Drop requirement of basket, card, comment, file, localperms and tag cubes for
cubicweb.server tests.
Copy needed part of schema, entities, views, hooks into the
cubicweb/server/test/data directory (which is included in PYTHONPATH for
CubicWebTC tests).
For migration tests which use different "datapath", use symlinks to have dependent cubes importables.

Variable "self.hm" is unused

This is test initialization, so use the setUpModule function for this

BaseConstraint doesn't have "name_for" method, this is just an addition for
cubicweb needs.

Implement this as a function instead of a monkeypatch to avoid having
"name_for" not defined because cubicweb.schema hasn't been imported.

In particular this fix running cubicweb/server/test/unittest_schema2sql.py::SQLSchemaTC::test_known_values alone.

_annotate_select() takes SQLGenAnnotator as a first argument and is
not used anywhere except in SQLGenAnnotator. This looks like a
method to me. Let us fold it into its class.

As in previous changesets, most code has been deprecated since a very
long time. This changeset concerns "core" cubicweb modules
(e.g. "server", "appobjects") for which it's not easy to handle change
atomically.

In cubicweb/server/querier.py, we adjust empty_rset() function as a
result of "rqlst" argument of ResultSet being dropped. (There was no use
of the keyword argument anyways.)

Changelog entry will come in a later changeset.

Also dropped an unused import along the way.

Changelog entry will come in a later changeset.

Changelog entry will come in a later changeset.

We actually drop *most* of deprecated code in this subpackage. What's
left is the MetaGenerator class in (cubicweb/dataimport/stores.py) which
is tricky to remove as it's still internally used by cubicweb.

Changelog entry will come in a later changeset.

This includes both Python and JavaScript code. Most code has been
deprecated since a very long time (versions 3.1x mostly, more than 5
years ago, and a few things until 3.24).

There are still a few deprecated things, most of which are actually used
within cubicweb (or in cubes we depend on for tests). I don't know what
to do with these...

Removed a couple of unused imports along the way.

Changelog entry will come in a later changeset.

Version 0.4.0 does not use a deprecated API that we are planning to drop
in forthcoming changesets.

This requires changing expected values in unittest_cwconfig.py where we
scan install cubes.

*   In CubicWebConfigurationTC.test_available_cubes(), localperms
    disappears from the list of expected cubes because this test method
    will look for new style cubes in located in cubicweb/test/data/libpython/
    (we patch pkg_resources.iter_entry_points()) as well as old style
    cubes installed in $PREFIX/share/cubicweb/cubes; since the new
    cubicweb-localperms version is new-style, it won't be catched by this
    method.

*   In CubicWebConfigurationWithLegacyCubesTC.test_available_cubes(),
    localperms is still listed, but now with the package name, because
    this method will simply look at installed cubes whether old or new
    style.

[test] Make the expected value explicit in CubicWebConfigurationWithLegacyCubesTC.test_available_cubes()

This will help with the next changeset, and avoiding computation in
tests is a good thing in general.

Improves readability.