GitLab

init scripts are no longer shipped.
Avoid mentionning "start" and "stop" command which should not be used in
production environments.

--HG--
branch : 3.26

This packages conflicts with cubicweb-ctl binary which uses the python2
library. It is meant to ease upgrade of existing installation during the
migration from python2 to python3: in particular, by installing
cubicweb-ctl3, scripts calling "cubicweb-ctl" command should still work
as before.

--HG--
branch : 3.26

When running `cubicweb-ctl newcube`, the generated template provides
debian packaging. So let's add automated tests for that using
autopkgtest.

The new test will generated a new cube, build a source tarball,
build the package, try to install it, see if the Python 2 and 3
modules are available and even run autopkgtest against the newly
created packages.

Along the way it will also print information about the generated
package: buildinfo, package content, and lintian report.

--HG--
branch : 3.26

Here are multiple updates to the Debian packaging template provided when
running `cubicweb-ctl newcube`:

 * Switch to source format 3.0 (quilt).
 * Switch to debhelper 9.
 * Switch to dh-python.
 * Add Python 3 packages.
 * Name the binary packages `python-cubicweb-CUBENAME` and
   `python3-cubicweb-CUBENAME` instead of just `cubicweb-CUBENAME` (which is
   still the source package).
 * Populate Depends using dh_python{2,3} support for Python requirements.
 * Run test suite at build time using pytest.
 * Add autopkgtest to run test suite against the installed package.
 * Bump Standards-Version to 4.3.0.

--HG--
branch : 3.26

--HG--
branch : 3.26

In order to implement automated testing of `cubicweb-ctl newcube`, we
need to avoid any user interaction. So we add a `-s` switch to specify
a short description on the command-line instead of requiring an input.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

This follows-up on changeset b2ceb483e056 (present in 3.25 as well), in
which AutomaticEntityForm.editable_attributes() was turned into a
generator. In this method, in case display_fields is not None, we
previously returned a list of (rtype, role); this was changed into a
yield, but the change was missing a return after the loop in order not
to go through the remainder of the function.

Add tests for editable_attributes() method.

--HG--
branch : 3.26

Fixes:

  cubicweb/web/views/autoform.py:703: [E122] continuation line missing indentation or outdented
  cubicweb/web/views/autoform.py:704: [E122] continuation line missing indentation or outdented
  cubicweb/web/views/autoform.py:819: [W504] line break after binary operator
  cubicweb/web/views/autoform.py:820: [E125] continuation line with same indent as next logical line
  cubicweb/web/views/autoform.py:961: [W504] line break after binary operator
  cubicweb/web/views/autoform.py:962: [E126] continuation line over-indented for hanging indent

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

* bash completion entry produces a lintian warning
  "package-installs-into-obsolete-dir etc/bash_completion.d/", and it does not
  install bash completion.
* doc directory should be handled automatically.

--HG--
branch : 3.26

Thus solving lintian warning "description-synopsis-starts-with-article".

--HG--
branch : 3.26

Fixing lintian warning "empty-binary-package".

--HG--
branch : 3.26

Fixes lintian warning "debhelper-but-no-misc-depends".

--HG--
branch : 3.26

This is to fix a Lintian warning.

--HG--
branch : 3.26

Previously, the binary package was empty. Now it is bound to
the python2 package as support for python3 is "fresh".

In order python2 and python3 packages to be co-installable, we drop the
cubicweb-ctl file from both packages.

--HG--
branch : 3.26

This is the bare minimum to have a working cubicweb on python3. Further
work is done in default branch.

--HG--
branch : 3.26

As suggested by Lintian, remove build dependency on obsolete package
dh-systemd. Instead, specify a more precise version of debhelper 9 that
added support for systemd.

--HG--
branch : 3.26

Since, for some reason, exception log messages are not visible when
running tests, it's very hard to debug when sendmails() method fails
during tests. So, as in some other places, let's raise the exception
when in test mode.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

The script should be installed normally as it is a setuptools' entry
point.

--HG--
branch : 3.26

We are not actually running tests during package build. (This was
disabled for python2, now it is also for python3.) And having these
build-depends makes it hard to rebuild the package.

--HG--
branch : 3.26

Extid can be bytes or text.

This avoid AttributeError: 'str' object has no attribute 'decode'

--HG--
branch : 3.26

What was happening
==================

The bug appears when ldapfeed tries to insert a user while another user exists
exists with a different source.

Simple use case to reproduce:

- create a local user in cubicweb (source=system)
- sync with ldap
- ldapfeed will stop complaining user already exists.

Without next patch the test MUST fail with message:
cubicweb/server/sources/native.py:714: UniqueTogetherError

The ldapfeed is thus stopped ignoring any further ldap entries.


The proposal
============

Prior to this patch, the insertion was trying to create all CWUser with the
computed login from eeimporter.extid2eid (method process of DataFeedLDAPAdapter).

When a CWUser existed with a different cw_source ("system" for user created
with cubicweb for instance), it created a conflict.

To avoid collisions, in the extentities_generator method a bypass
was added at the insertion layer.

Prior to insertion the absence of the computed login is checked on a list of
all existing login from a different source.

If collision is detected, we skip the ldap record.

By short circuiting at the CWUser entity insertion level we also avoid to treat
CWGroup and EmailAddress related to this user.
Hence ensuring a behaviour that will not break existing instances.
(conservative approach: faced with ambiguity better do nothing than guess).

An error message is added stating explicitly the conflict.

--HG--
branch : 3.26

Until someone works on fixing these, this should make our CI green
again.

I tried to use setupModule() to check for python version, but
pre_setup_database() is apparently called even when a SkipTest exception
is raised there. So handle this in that method.
(grafted from 4d68d20427de)

--HG--
branch : 3.26

--HG--
branch : 3.26

* Remove usage of unicode() and decode the base64-encoded string in
  encrypt();
* Encode the string received in decrypt() as (I supposed) it should come
  from the result of encrypt().

Add tests for this module along the way.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

From psycopg2 >= 2.8, specific exceptions are raised corresponding to
postgresql errors. E.g. a CheckViolation exception is raised instead of
a generic IntegrityError previously when a constraint violation occurs.
The way we intercept database errors, especially for constraint
violation, is not compliant with that because we do not catch subclasses
of IntegrityError in native source's doexec() method.

We fix this by checking for the presence of IntegrityError error in
exception class's mro. This is still overcomplicated and clumsy, because
we still use string comparison, but this is the best we can do as far as
I know. (A better fix would be 'isinstance(ex, IntegrityError)' but we
have no engine-independent error classes, so this is not possible.
Something like sqlalchemy's DBAPI Errors [1] might help:
https://docs.sqlalchemy.org/en/latest/errors.html#dbapi-errors)

--HG--
branch : 3.26

commit() might raise a AttributeError too.

Use getattr(req, 'cnx', req) instead, which is a form already used to get the real cnx
in some code:

cubicweb/rset.py:577:        cnx = getattr(self.req, 'cnx', self.req)
cubicweb/schema.py:353:                with getattr(_cw, 'cnx', _cw).security_enabled(read=False):

We could use if hasattr(req, 'commit') here too but it lead to 3 additionals lines.
Maybe we should have commit() and rollback() on
cubicweb.web.request.ConnectionCubicWebRequestBase too ?

--HG--
branch : 3.26

--HG--
branch : 3.26