GitLab

--HG--
branch : 3.26

```
$ python2
>>> str('a').decode('utf-8')
u'a'
$ python3
>>> str('a').decode('utf-8')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'str' object has no attribute 'decode'
```

Fixed with https://six.readthedocs.io/#six.ensure_str

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

This includes code made by Philippe Pepiot and Laurent Peuch
(revisions b10688370322 to 7f2e4c3518de), edited to add Python 2 support.

--HG--
branch : 3.26

In since c8c6ad8adbdb init_repository use repo.internal_cnx() instead of
repo.system_source.get_connection() so it use the pool and we should not close
cursors from the pool before returning it back. Otherwise we may have
"connection already closed" error.

This bug only trigger when connection-pool-size = 1. Since we are moving to use
a dynamic pooler we need to get this fixed.
This does not occur with sqlite since the connection wrapper instantiate new
cursor everytime, but this occur with other databases.

--HG--
branch : 3.26

If `self.lang` was already defined (aka not `None`), the language
was not set. In consequence, when a pview was called, the language
was always considered to be english, this piece of information is
used by gettext, so it resulted in translation always done in
english language instead of using user preference as excepted.

closes #87

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

To do so we use the functools "cmp_to_key" to convert from the
old cmp to the new key param type.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

'unicode' is not defined in python3

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

Modern ldap servers connection often use, or even require starttls.

--HG--
branch : 3.26

This was disabled because ldap3<2 wasn't compatible with python 3.7
While I'm here, drop unseless newline.

--HG--
branch : 3.26

* Some constants have been renamed.
* Directly bind when data-cnx-dn/data-cnx-password are provided, some servers,
  including ours require this.
* Use raise_exceptions=True to avoid ignored ldap errors
* raise in case of failed anonymous bind
* do not search for "dn" attribute because this raise an "invalid attribute"
  with new ldap3 versions
* Password is now returned as bytes, so no longer need to encode them before crypt.
* modification_date is now returned as a datetime object
Co-Authored-By: Philippe Pepiot <philippe.pepiot@logilab.fr>

Closes #16073071

--HG--
branch : 3.26

We already have LDAP_SCOPES dict defining possible scopes, this avoid possible code injection from config...
Thus we can drop global variables already defined in LDAP_SCOPES since they are not used directly anymore.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

When deleting entities, cubicweb run a rql DELETE on all relations to trigger hooks.
For an inlined relation this also mean set the column to NULL. This operation
may fail if there's additional constraints on the column.

Also this is a weird and useless behavior since deleting the entity row will by
definition delete the relation.

We still doesn't handle the case where both subject and object are going to be
deleted because rows need to be deleted in a particular order that cubicweb
doesn't handle.

Add a test checking UPDATE does not occur but hooks are correctly called.

Closes #17236690

--HG--
branch : 3.26

This test does nothing and is here from the begining of repo history.

Now it raise an error "TypeError: Skipped expected string as 'msg' parameter, got 'SkipTest' instead. Perhaps you meant to use a mark?"

Just drop it.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

When passing a unicode string to smtplib.SMTP.sendmail() as "msg"
argument, there is an implicit bytes encoding using "ascii" encoding in
python3. Of course this does not work if the string contains non-ASCII
characters. In fact, config's sendmails method intent to pass bytes to
smtplib.SMTP.sendmail() as it uses msg.as_string() method.
Unfortunately, in python3, this method returns a unicode string whereas
it returns a bytes string in python2; we thus fix this by calling
as_bytes() method on python3.

As there is no "as_bytes" method in python2, we need to handle python2
compatibility by hand and either call as_string() or as_bytes().

In testlib, where we mock smtplib.SMTP, we need to keep the "msg"
argument of Email class (defined in testlib as well) a unicode string.
Otherwise, it fails to be parsed by email.message_from_string() (from
stdlib) if it is bytes on python3.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

This solves a "python setup.py build" issue on my machine.
Copying these files should not be a big deal because they
have been dropped in the "default" branch and we would not
touch them in 3.26 branch.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

As pointed by Lintian, the “Apps” section is only used in menu,
not in doc-base. We can just remove it.

--HG--
branch : 3.26

Just use the now preferred location.

--HG--
branch : 3.26