1. 15 May, 2019 1 commit
  2. 08 Apr, 2019 1 commit
    • Denis Laxalde's avatar
      Account for new psycopg2 exception classes mapping · afafc8fd9a45
      Denis Laxalde authored
      From psycopg2 >= 2.8, specific exceptions are raised corresponding to
      postgresql errors. E.g. a CheckViolation exception is raised instead of
      a generic IntegrityError previously when a constraint violation occurs.
      The way we intercept database errors, especially for constraint
      violation, is not compliant with that because we do not catch subclasses
      of IntegrityError in native source's doexec() method.
      
      We fix this by checking for the presence of IntegrityError error in
      exception class's mro. This is still overcomplicated and clumsy, because
      we still use string comparison, but this is the best we can do as far as
      I know. (A better fix would be 'isinstance(ex, IntegrityError)' but we
      have no engine-independent error classes, so this is not possible.
      Something like sqlalchemy's DBAPI Errors [1] might help:
      https://docs.sqlalchemy.org/en/latest/errors.html#dbapi-errors)
      
      --HG--
      branch : 3.26
      afafc8fd9a45
  3. 16 Apr, 2019 1 commit
    • Philippe Pepiot's avatar
      [devtools/testlib] avoid hidding AttributeError in create_user() · 2508ba96fad2
      Philippe Pepiot authored
      commit() might raise a AttributeError too.
      
      Use getattr(req, 'cnx', req) instead, which is a form already used to get the real cnx
      in some code:
      
      cubicweb/rset.py:577:        cnx = getattr(self.req, 'cnx', self.req)
      cubicweb/schema.py:353:                with getattr(_cw, 'cnx', _cw).security_enabled(read=False):
      
      We could use if hasattr(req, 'commit') here too but it lead to 3 additionals lines.
      Maybe we should have commit() and rollback() on
      cubicweb.web.request.ConnectionCubicWebRequestBase too ?
      
      --HG--
      branch : 3.26
      2508ba96fad2
  4. 05 Apr, 2019 3 commits
  5. 12 Feb, 2019 1 commit
  6. 14 Mar, 2019 3 commits
  7. 13 Mar, 2019 1 commit
  8. 08 Mar, 2019 6 commits
  9. 07 Mar, 2019 1 commit
  10. 26 Feb, 2019 14 commits
  11. 27 Feb, 2019 1 commit
  12. 21 Feb, 2019 7 commits