GitLab

--HG--
branch : 3.26

--HG--
branch : 3.26

This solves a "python setup.py build" issue on my machine.
Copying these files should not be a big deal because they
have been dropped in the "default" branch and we would not
touch them in 3.26 branch.

--HG--
branch : 3.26

--HG--
branch : 3.26

When exploring the stack of all calls to a cubicweb-ctl command, it has been
discovered than on a KeyboardInterrupt and on a SystemExit exception the base
class InstanceCommand (for commands that works on one instance) will always set
the return code of cubicweb-ctl to 8: this mean that if another command do a
`sys.exit(some_code)` the exit code will be ignored and overwritten by '8'.

This behavior is not intuitive, apparently not documented and doesn't seems to
have any justification. It also prevent commands from exciting with different
return codes which could be a desired behavior in the situation of scripting.

Either use a decorator or ensure that cleanup is performed.

This is so as to prevent global state modification.

--HG--
branch : 3.26

As pointed by Lintian, the “Apps” section is only used in menu,
not in doc-base. We can just remove it.

--HG--
branch : 3.26

Just use the now preferred location.

--HG--
branch : 3.26

The documentation package was missing a Built-Using field to record
the provenance of the templates.

Empty packages or meta packages do not require Depends on a specific
Python version, so we can remove the relevant substvars.

--HG--
branch : 3.26

Quoting Lintian, “Since Debian Policy version 4.0.1, the priority extra
has been deprecated.” So let's use “optional” instead.

--HG--
branch : 3.26

This forces us to base the Debian package on the source of the Python
package (as produced by running `python3 setup.py sdist`). While
it might seem cumbersome, this greatly reduces likelyhood of mismatch
between an installation via `pip` and one using the Debian package.

`dpkg-source` will also document for us what is currently in the
source repository but not in the Python package. Currently the missing
file are:

PKG-INFO
cubicweb/sobjects/test/data/cubicweb_comment/schema.py
cubicweb/sobjects/test/data/cubicweb_comment/__init__.py
cubicweb/sobjects/test/data/cubicweb_comment/__pkginfo__.py
cubicweb/sobjects/test/data/cubicweb_card/schema.py
cubicweb/sobjects/test/data/cubicweb_card/entities.py
cubicweb/sobjects/test/data/cubicweb_card/__init__.py
cubicweb/sobjects/test/data/cubicweb_card/__pkginfo__.py
cubicweb/server/test/data-migractions/cubicweb_comment/schema.py
cubicweb/server/test/data-migractions/cubicweb_comment/__init__.py
cubicweb/server/test/data-migractions/cubicweb_comment/__pkginfo__.py
cubicweb/server/test/data-migractions/cubicweb_localperms/schema.py
cubicweb/server/test/data-migractions/cubicweb_localperms/__init__.py
cubicweb/server/test/data-migractions/cubicweb_localperms/__pkginfo__.py
cubicweb/server/test/data-migractions/cubicweb_basket/schema.py
cubicweb/server/test/data-migractions/cubicweb_basket/__init__.py
cubicweb/server/test/data-migractions/cubicweb_basket/__pkginfo__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_comment/schema.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_comment/__init__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_comment/__pkginfo__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_localperms/schema.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_localperms/__init__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_localperms/__pkginfo__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_basket/schema.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_basket/__init__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_basket/__pkginfo__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_tag/schema.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_tag/__init__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_tag/__pkginfo__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_card/schema.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_card/__init__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_card/__pkginfo__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_file/schema.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_file/__init__.py
cubicweb/server/test/data-migractions/migratedapp/cubicweb_file/__pkginfo__.py
cubicweb/server/test/data-migractions/cubicweb_tag/schema.py
cubicweb/server/test/data-migractions/cubicweb_tag/__init__.py
cubicweb/server/test/data-migractions/cubicweb_tag/__pkginfo__.py
cubicweb/server/test/data-migractions/cubicweb_card/schema.py
cubicweb/server/test/data-migractions/cubicweb_card/__init__.py
cubicweb/server/test/data-migractions/cubicweb_card/__pkginfo__.py
cubicweb/server/test/data-migractions/cubicweb_file/schema.py
cubicweb/server/test/data-migractions/cubicweb_file/__init__.py
cubicweb/server/test/data-migractions/cubicweb_file/__pkginfo__.py
cubicweb/test/data-rewrite/cubicweb_localperms/schema.py
cubicweb/test/data-rewrite/cubicweb_localperms/__init__.py
cubicweb/test/data-rewrite/cubicweb_localperms/__pkginfo__.py
cubicweb/test/data-rewrite/cubicweb_card/schema.py
cubicweb/test/data-rewrite/cubicweb_card/entities.py
cubicweb/test/data-rewrite/cubicweb_card/__init__.py
cubicweb/test/data-rewrite/cubicweb_card/__pkginfo__.py

The current manifest will duplicate several files that are stored as
symlinks in the Mercurial repository, hence the long list of ignored
files in `extend-diff-ignore`.

--HG--
branch : 3.26

init scripts are no longer shipped.
Avoid mentionning "start" and "stop" command which should not be used in
production environments.

--HG--
branch : 3.26

This packages conflicts with cubicweb-ctl binary which uses the python2
library. It is meant to ease upgrade of existing installation during the
migration from python2 to python3: in particular, by installing
cubicweb-ctl3, scripts calling "cubicweb-ctl" command should still work
as before.

--HG--
branch : 3.26

When running `cubicweb-ctl newcube`, the generated template provides
debian packaging. So let's add automated tests for that using
autopkgtest.

The new test will generated a new cube, build a source tarball,
build the package, try to install it, see if the Python 2 and 3
modules are available and even run autopkgtest against the newly
created packages.

Along the way it will also print information about the generated
package: buildinfo, package content, and lintian report.

--HG--
branch : 3.26

Here are multiple updates to the Debian packaging template provided when
running `cubicweb-ctl newcube`:

 * Switch to source format 3.0 (quilt).
 * Switch to debhelper 9.
 * Switch to dh-python.
 * Add Python 3 packages.
 * Name the binary packages `python-cubicweb-CUBENAME` and
   `python3-cubicweb-CUBENAME` instead of just `cubicweb-CUBENAME` (which is
   still the source package).
 * Populate Depends using dh_python{2,3} support for Python requirements.
 * Run test suite at build time using pytest.
 * Add autopkgtest to run test suite against the installed package.
 * Bump Standards-Version to 4.3.0.

--HG--
branch : 3.26

--HG--
branch : 3.26

In order to implement automated testing of `cubicweb-ctl newcube`, we
need to avoid any user interaction. So we add a `-s` switch to specify
a short description on the command-line instead of requiring an input.

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

This follows-up on changeset b2ceb483e056 (present in 3.25 as well), in
which AutomaticEntityForm.editable_attributes() was turned into a
generator. In this method, in case display_fields is not None, we
previously returned a list of (rtype, role); this was changed into a
yield, but the change was missing a return after the loop in order not
to go through the remainder of the function.

Add tests for editable_attributes() method.

--HG--
branch : 3.26

Fixes:

  cubicweb/web/views/autoform.py:703: [E122] continuation line missing indentation or outdented
  cubicweb/web/views/autoform.py:704: [E122] continuation line missing indentation or outdented
  cubicweb/web/views/autoform.py:819: [W504] line break after binary operator
  cubicweb/web/views/autoform.py:820: [E125] continuation line with same indent as next logical line
  cubicweb/web/views/autoform.py:961: [W504] line break after binary operator
  cubicweb/web/views/autoform.py:962: [E126] continuation line over-indented for hanging indent

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

--HG--
branch : 3.26

* bash completion entry produces a lintian warning
  "package-installs-into-obsolete-dir etc/bash_completion.d/", and it does not
  install bash completion.
* doc directory should be handled automatically.

--HG--
branch : 3.26

Thus solving lintian warning "description-synopsis-starts-with-article".

--HG--
branch : 3.26

Fixing lintian warning "empty-binary-package".

--HG--
branch : 3.26

Fixes lintian warning "debhelper-but-no-misc-depends".

--HG--
branch : 3.26

This is to fix a Lintian warning.

--HG--
branch : 3.26

Previously, the binary package was empty. Now it is bound to
the python2 package as support for python3 is "fresh".

In order python2 and python3 packages to be co-installable, we drop the
cubicweb-ctl file from both packages.

--HG--
branch : 3.26

This is the bare minimum to have a working cubicweb on python3. Further
work is done in default branch.

--HG--
branch : 3.26

As suggested by Lintian, remove build dependency on obsolete package
dh-systemd. Instead, specify a more precise version of debhelper 9 that
added support for systemd.

--HG--
branch : 3.26

Since, for some reason, exception log messages are not visible when
running tests, it's very hard to debug when sendmails() method fails
during tests. So, as in some other places, let's raise the exception
when in test mode.

--HG--
branch : 3.26

--HG--
branch : 3.26