GitLab

--HG--
branch : 3.25

--HG--
branch : 3.25

--HG--
branch : 3.25

--HG--
branch : 3.25

The function signature in the doc is not the same as in the code. Also option_removed should probably be removed from the doc since the function in migration.py is empty

--HG--
branch : 3.25

This may be necessary if a previous import did badly crached, leaving the
cwmassive_initialized behind.

--HG--
branch : 3.25

Postgres behaviour is to look first for a table in the configured schema then
fall back to 'public' if no table is found.

This must be implemented in deserialize_schema when listing existing tables
to check for computed relations (cw_cwcomputedrtype) otherwise computed
relations may not work when using non-default pg schema.

--HG--
branch : 3.25

while keeping bw-compat with 1.6 - 2.7 is not available for all distributions,
e.g. jessie.

The dependancy has been bumped in 6186cd15a46d because of a change in
bc9d901cb9e6. We may easily use the appropriate method depending on the version
installed.

--HG--
branch : 3.25

--HG--
branch : 3.25

--HG--
branch : 3.25

The "pyramid" instance configuration does not work with "cubiwceb.bwcompat"
mode (on purpose). Yet, having the setting exposed in development.ini file
(generate by `cubicweb-ctl create --config pyramid <cube> <instance>` command)
is misleading and we want to remove it.

Thus, we only query this setting when cubicweb configuration is "all-in-one" and
drop the setting line from templated development.ini file. If the option is
found and True for any other configuration type, we issue a user warning (and
ignore the option).

--HG--
branch : 3.25

For very old instances (namely docaster), this table has never been created.

--HG--
branch : 3.25

Iterate over relations type in alphabetical order, so the order is predictible
dans does not depend on PYTHONHASHSEED.

--HG--
branch : 3.25

--HG--
branch : 3.25

This is a regression appeared in 3.25.0. Appobjects (entities, views etc)
subpackages should be loaded recursively, this is the historical behavior,
relevant code is in logilab.common.registry._toload_info().
To keep historical behavior schema subpackages should not be loaded, relevant
code is in yams.reader.get_schema_files().
We may want to have a consistent behavior later on...

Closes #17073706.

--HG--
branch : 3.25

--HG--
branch : 3.25

--HG--
branch : 3.25

`entity.dc_long_title()` used to fallback to `dc_title()`, and most entity types
were relying on this, thus only implementing the later.

Since introduction of the IDublinCore adapter, if one call
`entity.dc_long_title()` on an entity that only implements `dc_title()`, it will retrieve
the adapter which will then call its own `title()` method instead of the
`dc_title()` method of the entity as expected.

Fix this by calling instead `entity.dc_title()` which will eventually kick in the
backward compat layer if necessary.

--HG--
branch : 3.25

There is a symlink in data directory (created by generate_static_dir() method)
and trying to rmtree() it will fail with an OSError. So we unlink() it
instead.

--HG--
branch : 3.25

--HG--
branch : 3.25

--HG--
branch : 3.25

--HG--
branch : 3.25

No need for a class method and easier to get proper logger including source's
name.

--HG--
branch : 3.25

for parts which are not located in some source's check_config / check_urls
method.

--HG--
branch : 3.25

Similarly as for config. Now, ldap source validation is properly done there
instead of at initialization time.

--HG--
branch : 3.25

Reintroduce usage of 'source.check_config' which had almost disappeared, as
well as tests for the currently detected errors.

Part of the system source specific checking done in syncsources reimplemented in
a specific check_config implementation.

Tests are dispatched among ldap / datafeed and syncsources tests but are not
strictly correctly located (notably syncsources tests behaviour of the native
source's check_config).

The system source url checking part which disappears from syncsources will be
reintroduced in a follow-up.

--HG--
branch : 3.25

which wasn't actually testing what it expected (and nothing guarantee it does now, but that's another story).

Fixing this will avoid failure once we properly check the configuration.

--HG--
branch : 3.25

* mark it private
* explicit name
* update docstring

Private function is still called from syncsources but this will be updated in a
follow-up.

--HG--
branch : 3.25

this should be done later in the web ui, where lang is properly set.

--HG--
branch : 3.25

Only call it when enabled instead of giving a boolean flag indicating whether it
is or not (which were not correctly considered).

--HG--
branch : 3.25

It's not used anymore within cubicweb itself.

--HG--
branch : 3.25

Most of the times we only need to retrieve one source (either by uri or eid)
and querying sources_by_eid and sources_by_uri properties on repository just
for one item is costly. So these methods query what's needed. We issue a
ValueError (instead of KeyError for sources_by_{eid,uri} dict) in case the key
is not found.

--HG--
branch : 3.25

There's no need to convert it as a list anymore since sources_by_uri is a
property and will not be modified.

--HG--
branch : 3.25

This _entity_update method does not make sense now that we do not update
source from database information but always build them afresh.

--HG--
branch : 3.25

It does not make sense anymore to update the config of a source instance
(subclass of cubicweb.server.sources.AbstractSource) now that they are always
built from database information (CWSource). In datafeed and ldapfeed, we
move all code from "update_config" method in "init" method.

This changeset fixes LDAPFeedUserDeletionTC.test_a_filter_inactivate() failure
(unittest_ldapsource.py) introduces in previous changeset.

--HG--
branch : 3.25

I.e. do not populate these dict as repo initialization (bootstrap step) but
always use information from database. This is needed because when multiple
instances of the same application run, if one instance adds a CWSource the
other ones will not see it. In particular, when using a scheduler instance,
new CWSource will be added by the web instance and not seen by the scheduler
which is supposed to update them.

We thus define properties for sources_by_eid and sources_by_uri instead
attributes on repository instance. CWSource entities are thus retrieved from
database every time these properties are accessed. We factor out
initialization of the "source" instance (subclass of
cubicweb.server.source.AbstractSource) in a _sources() method. Note that this
method takes care of calling "init" method on the source as well as
"set_schema" (previously done in repo.set_schema(), which now only touches
system_source). Accordingly the "init_sources_from_database" method is dropped
along with "add_source"/"remove_source" methods.

In syncsources hook, we thus drop:

* SourceAddedOp operation which called repo.add_source() so that the
  SourceAddedHook only cares about checking source configuration now;
* SourceRemovedOp and SourceRenamedOp operations for the same reason;
* SourceConfigUpdatedOp as updating the live config of source is
  meaningless once we rely on them being retrieved from the database;
* SourceHostConfigUpdatedHook hook which is now useless without call to
  SourceConfigUpdatedOp;

In 3.10 migration script, remove usage of sources_by_uri repo attribute which,
unless I'm missing something, appears useless (at least now).

In tests:

* unittest_datafeed: remove test_update_url method since we dropped respective
  hook;
* unittest_ldapsource: LDAPFeedUserDeletionTC.test_a_filter_inactivate()
  currently fails because it still relies on live config being updated, this
  will be fixed in the next changeset once all "live source" logic will be
  removed.

--HG--
branch : 3.25

For the CubicWeb project and its dependencies, we now prefer patches
submission and review by email on a public mailing list. We are thus moving
away from the previous vcreview-based workflow taking place on the forge.
This change is motivated by the following points:

- the current reviewer assignment mechanism (pick a random reviewer, rely on
  reviewer availability rather than on willingness to review, send related
  patches to distinct people, etc.) is inefficient if not counter-productive;
- most of the times, discussion only happens between the patch submitter and a
  reviewer with no easy way to increase the audience;
- cubicweb-vcreview has no concept of patch series;
- cubicweb-vcreview is not actively maintained anymore and its usability keeps
  deteriorating.

We expect that email-based submission and review of patches will circumvent
these limitations. Anybody interested in the project is welcome to subscribed
to the mailing list and participate to the review process.

This patch documents the basic workflow of patches submissions by email.

--HG--
branch : 3.25

deleting the directory itself is useless and may be a problem in automated
deployment environments (user may not have permissions to delete or create
that directory).

--HG--
branch : 3.25

--HG--
branch : 3.25

I don't know what this is for exactly, but the accept_mode method below
queries this dict with the configuration type name. And if the latter is
"pyramid", it crashes since there's no key in MCOMPAT dict. So add one with
the same value as "all-in-one". This code is called during "upgrade"
migration in particular.

--HG--
branch : 3.25