Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
cubicweb
cubicweb
Commits
3226314d84ba
Commit
9d8fa722
authored
Apr 12, 2020
by
Simon Chabot
Browse files
fix(tests): return code, after SIGTERM received, is -15, not 0.
related:
#1
--HG-- branch : 3.27
parent
70e98143ee1d
Changes
1
Hide whitespace changes
Inline
Side-by-side
cubicweb/devtools/qunit.py
View file @
3226314d
...
...
@@ -96,8 +96,11 @@ class FirefoxHelper(object):
assert
self
.
_process
.
returncode
is
None
,
self
.
_process
.
returncode
self
.
_process
.
terminate
()
self
.
_process
.
wait
()
assert
self
.
_process
.
returncode
==
0
,
"Error: firefox return code is %s, see %s"
%
\
(
self
.
_process
.
returncode
,
self
.
log_file
)
# terminate() sends the signal SIGTERM to the process, which has
# value 15, therefore the returncode should be -15.
# https://docs.python.org/3/library/subprocess.html#subprocess.CompletedProcess.returncode
assert
self
.
_process
.
returncode
==
-
15
,
"Error: firefox return code is %s, see %s"
%
\
(
self
.
_process
.
returncode
,
self
.
log_file
)
self
.
_process
=
None
def
__del__
(
self
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment