Commit 32bb941c authored by Denis Laxalde's avatar Denis Laxalde
Browse files

[test] use self.assertRaises() in cwctl tests

parent 5e7212209ea6
...@@ -113,28 +113,26 @@ class InstanceCommandTest(unittest.TestCase): ...@@ -113,28 +113,26 @@ class InstanceCommandTest(unittest.TestCase):
@patch.object(_TestCommand, 'test_instance', return_value=0) @patch.object(_TestCommand, 'test_instance', return_value=0)
def test_getting_called(self, test_instance): def test_getting_called(self, test_instance):
try: with self.assertRaises(SystemExit) as cm:
self.CWCTL.run(["test", "some_instance"]) self.CWCTL.run(["test", "some_instance"])
except SystemExit as ex: # CWCTL will finish the program after that self.assertEqual(cm.exception.code, 0)
self.assertEqual(ex.code, 0)
test_instance.assert_called_with("some_instance") test_instance.assert_called_with("some_instance")
@patch.object(cwctl, 'get_pdb') @patch.object(cwctl, 'get_pdb')
def test_pdb_not_called(self, get_pdb): def test_pdb_not_called(self, get_pdb):
try: # CWCTL will finish the program after that
with self.assertRaises(SystemExit) as cm:
self.CWCTL.run(["test", "some_instance"]) self.CWCTL.run(["test", "some_instance"])
except SystemExit as ex: # CWCTL will finish the program after that self.assertEqual(cm.exception.code, 0)
self.assertEqual(ex.code, 0)
get_pdb.assert_not_called() get_pdb.assert_not_called()
@patch.object(cwctl, 'get_pdb') @patch.object(cwctl, 'get_pdb')
def test_pdb_called(self, get_pdb): def test_pdb_called(self, get_pdb):
post_mortem = get_pdb.return_value.post_mortem post_mortem = get_pdb.return_value.post_mortem
try: with self.assertRaises(SystemExit) as cm:
self.CWCTL.run(["test_fail", "some_instance", "--pdb"]) self.CWCTL.run(["test_fail", "some_instance", "--pdb"])
except SystemExit as ex: # CWCTL will finish the program after that self.assertEqual(cm.exception.code, 8)
self.assertEqual(ex.code, 8)
get_pdb.assert_called_once() get_pdb.assert_called_once()
post_mortem.assert_called_once() post_mortem.assert_called_once()
...@@ -142,10 +140,9 @@ class InstanceCommandTest(unittest.TestCase): ...@@ -142,10 +140,9 @@ class InstanceCommandTest(unittest.TestCase):
@patch.dict(sys.modules, ipdb=MagicMock()) @patch.dict(sys.modules, ipdb=MagicMock())
def test_ipdb_selected_and_called(self): def test_ipdb_selected_and_called(self):
ipdb = sys.modules['ipdb'] ipdb = sys.modules['ipdb']
try: with self.assertRaises(SystemExit) as cm:
self.CWCTL.run(["test_fail", "some_instance", "--pdb"]) self.CWCTL.run(["test_fail", "some_instance", "--pdb"])
except SystemExit as ex: # CWCTL will finish the program after that self.assertEqual(cm.exception.code, 8)
self.assertEqual(ex.code, 8)
ipdb.post_mortem.assert_called_once() ipdb.post_mortem.assert_called_once()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment