Commit 17cc9787 authored by Philippe Pepiot's avatar Philippe Pepiot
Browse files

[server] prevent returning closed cursor to the database pool

In since c8c6ad8adbdb init_repository use repo.internal_cnx() instead of
repo.system_source.get_connection() so it use the pool and we should not close
cursors from the pool before returning it back. Otherwise we may have
"connection already closed" error.

This bug only trigger when connection-pool-size = 1. Since we are moving to use
a dynamic pooler we need to get this fixed.
This does not occur with sqlite since the connection wrapper instantiate new
cursor everytime, but this occur with other databases.

--HG--
branch : 3.27
parent f32b158d8fed
......@@ -253,7 +253,6 @@ def init_repository(config, interactive=True, drop=False, vreg=None,
print('The following SQL statements failed. You should check your schema.')
print(failed)
raise Exception('execution of the sql schema failed, you should check your schema')
sqlcursor.close()
sqlcnx.commit()
with repo.internal_cnx() as cnx:
# insert entity representing the system source
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment