# HG changeset patch # User Katia Saurfelt <katia.saurfelt@logilab.fr> # Date 1394640593 -3600 # Wed Mar 12 17:09:53 2014 +0100 # Node ID 45b3eb604765f7963941c1ad2fdeba0af6dcc839 # Parent 0de68c23d372cd31a92398b5639bf519974e6be4 [boxes] do not write HTML markup for aside columns if no box content available (closes #3643330) diff --git a/views/basetemplates.py b/views/basetemplates.py --- a/views/basetemplates.py +++ b/views/basetemplates.py @@ -116,12 +116,15 @@ @monkeypatch(basetemplates.TheMainTemplate) def nav_column(self, view, boxes, context): if boxes: - getlayout = self._cw.vreg['components'].select - self.w(u'<div id="aside-main-%s" class="col-md-3">\n' % - context) + html = [] for box in boxes: - box.render(w=self.w, view=view) - self.w(u'</div>\n') + box.render(w=html.append, view=view) + if html: + # only display aside columns if html availble + self.w(u'<div id="aside-main-%s" class="col-md-3">\n' % + context) + self.w(u'\n'.join(html)) + self.w(u'</div>\n') return len(boxes) @monkeypatch(basetemplates.TheMainTemplate)