- 01 Sep, 2017 4 commits
-
-
Sylvain Thénault authored
As explained in the previous commit, we want items with cardinality = 1 first then the one with cardinality != 1 if any. See previous commit for detailed explanation. Closes #17098404
-
Sylvain Thénault authored
By trying to validate several profiles using Jing (in Asalae), it appears that it isn't possible to validate a profile where there are several elements with the same name with optional or/and multiple cardinality, e.g. with a profile telling we expect 1..n Document followed by 1 Document, a transfer with two documents won't be accepted, telling a required document is missing. This is much probably because the validator "eats" the two documents for the first rule, then it misses one to satisfy the second rule. In order to avoid generating such insatisfyable profiles, while not changing much the UI for now, we decided to add hook preventing usage of several sibling children with a cardinality != 1 during edition, and then at RNG profile generation time to put the one with cardinality != 1 as last children. That way profiles should always be validable. This patch introduces the hooks preventing insatisfyable profiles to be created. The next one will ensure the order of RNG export. Two hooks are added to check for unhandled case one for new watched relations and the other for update cardinalities. Added test cases for the 3 most prominent cases: archive unit, document and keywords, with more coverage in the first one and only simple check for the two others. Also, some test have to be updated to follow this change. Notice diff of exported RNG isn't nice to read but is actually only removal of a surrounding "oneOrMore" element. Related to #17098404
-
Sylvain Thénault authored
Those structures will be used as bases for hooks necessary to check for unhandled cardinalities, that will be introduced by the following change set. We have to watch composite relation that may lead to several children, and for the entity types that are possible as children. Related to #17098404
-
Sylvain Thénault authored
-
- 31 Aug, 2017 3 commits
-
-
Sylvain Thénault authored
This has several advantages: * it's consistent with xsd/rng defaults * it simplifies code * it may avoid undesired validation error once #17098404 will be fixed This requires several test update, fixed by a mix of test case update or expected data update to minimize the changes. Related to #17098404
-
Sylvain Thénault authored
-
Sylvain Thénault authored
-
- 29 Aug, 2017 1 commit
-
-
Sylvain Thénault authored
else this won't be conform to the SEDA 0.2schema. But notice this is the opposite in SEDA 1.0. In this case, test cases were fine but the problem was actually the same: data-objects and sub-units order was random, and it's not anymore. As we are here, add eid so we get a total ordering, which is an expected property so that exported profiles are consistent during time. This should be enough until we want to control ordering from the UI. Closes extranet #33070904
-
- 24 Aug, 2017 3 commits
-
-
Sylvain Thénault authored
Ensure language priority.
-
Sylvain Thénault authored
We should override the concepts_language class attribute else we'll use the inherited 'seda-1' language.
-
Sylvain Thénault authored
this will ease testing of other things in this module (as in following cset).
-
- 16 Aug, 2017 1 commit
-
-
Sylvain Thénault authored
Values are not SEDA 2 specific, they should be used for every SEDA version, so change 'SEDA-2' into 'SEDA' else the english value is used for SEDA 1.0 and 0.2. Closes extranet #32206261
-
- 20 Jul, 2017 5 commits
-
-
Sylvain Thénault authored
-
Sylvain Thénault authored
-
Sylvain Thénault authored
because 0.10.4 has been published with a 0.10.5 migration script :(
-
Sylvain Thénault authored
-
Sylvain Thénault authored
-
- 19 Jul, 2017 2 commits
-
-
Sylvain Thénault authored
3 letters code should be the default seda value, while seda 0.2 want two letters code.
-
Sylvain Thénault authored
6 is not enough to hold 'seda-02', move to 7.
-
- 22 Jun, 2017 1 commit
-
-
Sylvain Thénault authored
since it does not have a unit. Closes #17085681
-
- 13 Jun, 2017 4 commits
-
-
Sylvain Thénault authored
missed by 8f1a4f7abbf6 Related to extranet #25271719
-
Sylvain Thénault authored
in which case we want the cardinality to be editable. To fix this, we've to consider inlined creation view's "petype" parameter. This has probably not be necessary until now becase SEDAStartDate wasn't until recently editable at entity creation time. Closes #17084051
-
Sylvain Thénault authored
only keep the last one. Related to #17084051
-
Sylvain Thénault authored
instead of hard-coded 'language'. We should also match seda_originating_agency_from. This heuristic is already used in e.g. `rtags_from_rtype_role_targets` function. Closes #17084054
-
- 06 Jun, 2017 2 commits
-
-
Sylvain Thénault authored
-
Sylvain Thénault authored
-
- 01 Jun, 2017 2 commits
-
-
Sylvain Thénault authored
It should appears first for SEDA 1.0 and after custodial history in SEDA 0.2. Update export test accordingly and add Description to SEDA 0.2 validation test. Closes extranet #23707701
-
Sylvain Thénault authored
since this is handled by the caller.
-
- 18 May, 2017 1 commit
-
-
Sylvain Thénault authored
RNG doesn't handle ID/IDREF as XSD: it doesn't handle having some tag's *content* of such type, as it is the case in SEDA 2 ObjectReferenceId element. See https://www.oasis-open.org/committees/relax-ng/compatibility.html#id for details. To fix this, 'downgrade' ID into NCName. This was already done when some data object was referenced, but it should actually be done systematically. Closes #17078970
-
- 10 May, 2017 2 commits
-
-
Sylvain Thénault authored
-
Sylvain Thénault authored
-
- 27 Apr, 2017 2 commits
-
-
Sylvain Thénault authored
of entity and relation types in the compound tree. This ensure that permissions of the whole tree depends on permission of the root (SEDAArchiveTransfer or SEDAArchiveUnit), with no special cases for users in the managers group. Related to extranet #19216837
-
Sylvain Thénault authored
since an archive transfer may have only one seda_comment relation and the tested entity already has one, rather use another to demonstrate the unauthorized permission.
-
- 21 Apr, 2017 5 commits
-
-
Sylvain Thénault authored
Closes extranet #18337720
-
Sylvain Thénault authored
test are failing otherwise, because code has to be removed from site_cubicweb.
-
Sylvain Thénault authored
vs creation of component archive unit, in which case it should return a positive score, not zero. This is because in such case, container can't be detected and implementation trapped this and returned 0. In such case, we must check if we're creating an archive unit and return 1 if so. Closes extranet #18337031
-
Sylvain Thénault authored
since it's not the same thing as the entity received in arguments.
-
Sylvain Thénault authored
by avoiding `au_content_afs` copy of `afs`, which may be unwillingly selected while for instance `simplified_afs` is expected. Since this is tricky to handle, simplify things a bit by adding rules formerly in `au_content_afs` as default rules and only create on custom `afs` copy for 'reference' archive unit. Related to extranet #18337031
-
- 18 Apr, 2017 1 commit
-
-
Sylvain Thénault authored
-
- 13 Apr, 2017 1 commit
-
-
Sylvain Thénault authored
consistently with the primary view.
-