GitLab

And drop monkeypatch now in this version.

There may be cases where several concepts use the same label, mostly in the case
of format identifier but do the same thing for mime types as a safety belt.

because they don't need the heavy setup of the former class.

this is so annoying.

Since the operation may be triggered by deletion of the relation, it may be
unadvertanly called by cascade when the data-object is being deleted.

introduced by c463fd270e81.

This should be specially handled even when the cloning starts from the archive
transfer.

Requires a yet unreleased fix in the compound cube.

e.g. while debugging an instance I attempted to display result of 'Any X, C
WHERE X container C' with unexpectedly to container for the entity, but I wasn't
able to display it because rset.one() raised an error since len(rset) was 2.

Even if the caller may be wrong, it seems ok to not call rset.one() if function
is called in an erroneous context and simply return None in such case.

And call the ajax API accordingly. We now allow on top of the earlier
"maybeParentOf" mecanism:

* to reorder binary / physical data object
* to reorder archive units.

To do so, we:

* turn 'inside' position while moving a node which is already a children node
  into 'before' + first children as target node,

* check if the position is correct, provided that we don't want to mix types:
  binary objects should be before physical objects which should be before
  archival units,

* call the ajax API by giving it the relative index above mentionned (i.e. index
  of the node within nodes of the same type).

by implementing ajax entry point and API on the jqtree adapter.

by implementing it on the JQTree adapter, but with only hard-coded position in
the js for now.

since this will soon become even more SEDA dependant.

because we have to keep this property in the targeted ordering implementation.

this is only unit-tested for now, it will be actually used by later commits.

so all implementation details of this ordering management is at the same place.

and move it to the itree module since this is entity logic, not view.

this is not used (left-over of some debugging session?)

and remove a useless assign along the way (we already had a reference on the
targeted entity)

moving an archive unit from a transfer to another is not the actual use-case,
it's about moving an archive unit to another parent in the same tree.

based on reference's ordering attribute. Use the reference and not the data
object's ordering because it's the one used on the data objects tab for
simplified profiles.

it avoid forgetting it and is easier to grasp.

rather use ORM controlled order, consistently with the UI. Let the doctor
diagnose ambiguities (done in previous commit).

This backout most parts of 4941eab6a289.

so it's importable at code generation time where the cubicweb_seda package isn't
available.

it's an implementation specific attribute, we don't want to see it in the UI.

in order to being able to order children elements of an entity.

This will be desired in following csets since we'll stop ordering RNG export
using cardinality to follow user enforced ordering, hence consistently with the
UI.

I don't think we care about such rules'order and they should usually be fixed in
the profile, so don't check them.

If one wish to check them at some point, it should add ordering on relevant
entities and extend consistently the xsd2yams.MULTIPLE_CHILDREN list.

after discussion with B. Nichelle from the SIAF, it appears that some cases are
actually handled as expected, some others not.

this is required with recent pytest to avoid cluttered output with duplicated
cubicweb's logging message (there must have something to fix on the cubicweb
side to avoid this).

so we're properly redirected after creation of their associated subobjects.

duh.

and add a test for ambiguous units under a sub-unit, to have a case for archive
units handled by each query.