GitLab

update undo_manager property, type:
  self._undo_manager as SelectionManager
and fix:
  rql/stmts.py:424: error: Cannot determine type of "_undo_manager" [has-type]

rewrite the undo_manager function and make sure it always returns a SelectionManager

- remove even more useless comments
- remove even more useless casts

if we want to use it as 2nd arg to the property function:
- set_limit method should explicitly return None
- remove useless comments
- remove now useless type:ignore comments

This fix mypy error:
Argument 2 to "property"
 has incompatible type "Callable[[rql.stmts.Union, Any], Optional[rql.stmts.Union]]"
 expected "Optional[Callable[[Any, Any], None]]"

- annotate schema as ISchema
- remove useless comments
- remove useless cast
- remove now useless type:ignore comments

Inside stmts module,
somewhere we read, `self.groupby` attribute being added if not exists and used as a list:
```
if not self.groupby:
    self.groupby = []
```

Let's just define:
- self.groupby self.orderby as instance attribute
- self.groupby self.orderby as List of Any
- remove the if not self.grouby check

Do the same with the `self.orderby` attribute.

Inside Select class:
- update `remove` method signature. And fix the error:
  rql/stmts.py:940: error:
  Argument 1 to "remove_sort_term" of "Select" has incompatible type "BaseNode";
  expected "SortTerm"  [arg-type]

- update undefine_variable method:
  remove useless check of var.variable attribute

Inside undo.NodeOperation class:
- simplify type hint for `node` parameter inside `NodeOperation.__init__` method

Update rql.base.Node class:
- define self.parent as a TypeVar
- define self.children as a List of TypeVar
- Those 2 TypeVar are bound, i.e: they can be BaseNode or any children of BaseNode

Update rql.stmts.Union class:
- add a new attribute, i.e:  `children: List["rql.stmts.Select"]`

Update rql.RQLHelper simplify & _simplify methods:
- remove call to cast method, no more need to cast from BaseNode to Select

Also:
- Try to harmonize type signature for get_description methods
- Remove now obsolete comments related to type hints
- type vconsts as a List of Constant

1. Define a custom type: TranslationFunction:
This depends on `Protocol` which is only available on python >= 3.8.
`typing_extensions` provides it for lower versions.

2. Update get_description function signature:
For `tr` parameter, Use TranslationFunction instead of Callable[[str, str], str]

3. get_description signature redefined, stop ignoring call-arg errors

- update tox configuration, add black environment
- format the whole project
- update Gitlab CI config add a job for black

- Add types within stcheck.py module
- Update the accept & leave methods signatures inside the VisitableMixIn class
- Redefine type (and set a type alias) for Select.vargraph attribute

- make sure remove method & replace method have the same signature
- make sure to use 'rql.base.BaseNode' instead of 'BaseNode' when typing

with_ used to be a class attribute, shared by all the instances. Some tricks
were used to redefine it as an instance attribute on the fly. It was leading to
an infinite recursion.

Let's simplify all of this, and remove the magic. Instance attributes should be
defined in the __init__.

TargetRenamedDeprecationWarning: [logilab.common.deprecation] deprecated has been renamed and is deprecated, uses callable_de
precated instead

We're going to remove python2 support so we can remove six as well.